[ACS] az aks create: Make --no-ssh-key default behaviour#32115
Merged
[ACS] az aks create: Make --no-ssh-key default behaviour#32115
az aks create: Make --no-ssh-key default behaviour#32115Conversation
Update template spec operations to extract and use the subscription ID from the resource ID if provided. Add tests to verify correct handling of subscription IDs in show, update, delete, and export commands for template specs.
Deleted test cases and YAML recordings related to template spec operations using a fake subscription ID. These tests were unnecessary as the functionality is already tested in other tests.
Removed redundant subscription_id variable assignments in template spec-related functions. Now, subscription_id is passed directly from parsed resource ID when template_spec is provided, improving code clarity and reducing duplication.
Introduces new test cases to validate update, show, delete and export operations for template specs using an auxiliary subscription.
Introduces the 'tags' argument to SQL server creation commands in _params.py. Adds a new test and recording to verify server creation with tags in test_sql_commands.py and corresponding YAML recording.
Added a new usage example to the SQL server create command help, demonstrating how to specify tags during server creation.
Refreshed test recording for SQL server creation with tags to reflect new API versions, updated timestamps, and changed response metadata. Ensures test compatibility with latest Azure CLI and service API updates.
Enhanced the logic for SSH key validation in AKS cluster creation to default to server-side generated keys if no local public key is found and no value is provided. Updated help documentation to clarify SSH key behavior. Added a test and recording for AKS creation without an SSH key.
a0x1ab
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
1 task
Simplified the assignment of the SSH key path in validate_ssh_key by improving readability.
FumingZhang
reviewed
Sep 15, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Per discussion in the issue, this should be regarded as a breaking change, could you please follow the guidance to send out the notification first?
Refactored the SSH key validation in _validators.py to handle empty or invalid SSH key values more robustly and provide clearer error messages. Updated test recordings to reflect changes in AKS creation without an SSH key.
Member
please also fix failed CI checks |
Simplified the validate_ssh_key function by removing an unnecessary else block before raising a CLIError for invalid SSH keys.
Adjusted the error message in validate_ssh_key to properly break lines for improved readability and consistency.
FumingZhang
reviewed
Sep 22, 2025
Contributor
|
please fix the live test failure. |
yanzhudd
modified the milestones:
October 2025 (2025-10-14),
November 2025 (2025-11-04)
Member
Author
Due to the breaking change, this PR will need to be merged in the following sprint. |
FumingZhang
reviewed
Oct 2, 2025
FumingZhang
previously approved these changes
Oct 2, 2025
Collaborator
|
Please fix CI issues |
Member
Author
Thank you @yonzhan, I have fixed the linting errors |
FumingZhang
approved these changes
Oct 3, 2025
Member
|
No breaking change is allowed in a normal release. Please revert this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
aks
Description
aks createcommand was run without any ssh related parameters, the command would failaks createcommand to operate under the pretense that --no-ssh-key was provided as a parameterTesting Guide
az aks createwith the required parameters and omitting all ssh related parametersThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.